Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and changelog to sdist #436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tests and changelog to sdist #436

wants to merge 1 commit into from

Conversation

jayvdb
Copy link

@jayvdb jayvdb commented Sep 1, 2022

No description provided.

@adamchainz
Copy link
Member

I recommend not distributing the tests. 99.99% of installs do not need them. Those who want them are normally redistributors, can who fetch the tarball from the repo. Last year I removed tests from the sdists in all my projects and heard no complaints.

Is redistributing your motivation here @jayvdb ? Have you considered using repo tarballs?

@jayvdb
Copy link
Author

jayvdb commented Sep 1, 2022

https://pypi.org/project/daphne/#files includes wheels, which is what 99% of installs will fetch.
The sdist is for the other 1% need.

Yes, https://build.opensuse.org/package/show/devel:languages:python:django/python-django-cors-headers and https://build.opensuse.org/package/show/devel:languages:python:django/python-django-upgrade were broken when tests were removed, which is why they have not been updated , because the automated update system only works when fetching from pypi.

Using tarballs from github is more effort, which I will do because these are important packages and they are already in the openSUSE collection. Before adding new packages to openSUSE, and thus more work, I try to have the sdists on PyPI include tests, as I did in adamchainz/django-cors-headers#378 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants