Code

Refactor main#update_quality#1

Code

Draft

dkubb wants to merge 38 commits intomasterdkubb/gilded_rose_kata:masterfrom dkubb/solution1dkubb/gilded_rose_kata:dkubb/solution1Copy head branch name to clipboard

+109-44

Commits

Commits on Jun 5, 2020

• Add Github Actions configuration

  Show description for 2ef1814
  dkubb

  committed
  2ef1814

  Copy full SHA for 2ef1814

• Fix conjured item tests that are failing to be pending

  Show description for b668d36
  dkubb

  committed
  b668d36

  Copy full SHA for b668d36

• Fix rspec warning for deprecated should syntax

  dkubb

  committed
  4d22553

  Copy full SHA for 4d22553

• Add ItemUpdater to handle main#update_quality inner loop behaviour

  Show description for 02f4f5a
  dkubb

  committed
  02f4f5a

  Copy full SHA for 02f4f5a

• Move main#update_quality below ItemUpdater

  dkubb

  committed
  a5d8f57

  Copy full SHA for a5d8f57

• Remove ItemUpdater#item alias method

  Show description for 5717d9e
  dkubb

  committed
  5717d9e

  Copy full SHA for 5717d9e

• Refactor ItemUpdater#call to use implicit self where possible

  dkubb

  committed
  0905d6b

  Copy full SHA for 0905d6b

• Refactor ItemUpdater#call to use a centralized bounds check on quality

  Show description for a278022
  dkubb

  committed
  a278022

  Copy full SHA for a278022

• Refactor ItemUpdater#call so most conditionals are not negated

  Show description for 95f1e61
  dkubb

  committed
  95f1e61

  Copy full SHA for 95f1e61

• Refactor ItemUpdater#call so that conditional branches are collapsed

  Show description for 22aca3a
  dkubb

  committed
  22aca3a

  Copy full SHA for 22aca3a

• Refactor ItemUpdater#call so backstage pass conditionals are reversed

  Show description for f919a72
  dkubb

  committed
  f919a72

  Copy full SHA for f919a72

• Refactor ItemUpdater#call so backstage pass conditional is simpler

  dkubb

  committed
  57ac6a9

  Copy full SHA for 57ac6a9

• Refactor ItemUpdater#call so backspace pass branch is moved to parent

  Show description for 5e3ee26
  dkubb

  committed
  5e3ee26

  Copy full SHA for 5e3ee26

• Refactor ItemUpdater#call so backspace pass conditional is more clear

  Show description for e6228c8
  dkubb

  committed
  e6228c8

  Copy full SHA for e6228c8

• Refactor ItemUpdater#call so backspace pass quality incr is simpler

  Show description for 6a2a0ca
  dkubb

  committed
  6a2a0ca

  Copy full SHA for 6a2a0ca

• Refactor ItemUpdater#call so backspace pass quality reset is simpler

  Show description for dbe6a8b
  dkubb

  committed
  dbe6a8b

  Copy full SHA for dbe6a8b

• Refactor ItemUpdater#call so sell_in is incremented earlier

  Show description for 37bd62c
  dkubb

  committed
  37bd62c

  Copy full SHA for 37bd62c

• Refactor ItemUpdater#call sell_in value test to use #negative?

  dkubb

  committed
  290ff8f

  Copy full SHA for 290ff8f

• Add ItemUpdater#expired?

  dkubb

  committed
  54f9b65

  Copy full SHA for 54f9b65

• Refactor ItemUpdater#call so normal items decr quality after expiry

  dkubb

  committed
  557144c

  Copy full SHA for 557144c

• Refactor ItemUpdater#call so backstage passes reset quality after expiry

  Show description for 0e2c694
  dkubb

  committed
  0e2c694

  Copy full SHA for 0e2c694

• Refactor ItemUpdater#call so brie increases in quality as it ages

  dkubb

  committed
  312accd

  Copy full SHA for 312accd

• Refactor ItemUpdater#call so item quality is only changed once

  Show description for 796be3f
  dkubb

  committed
  796be3f

  Copy full SHA for 796be3f

• Change ItemUpdater#call so normal item quality changes by negative value

  Show description for 0163193
  dkubb

  committed
  0163193

  Copy full SHA for 0163193

• Refactor ItemUpdater#call to use constants for item names

  dkubb

  committed
  34b84cc

  Copy full SHA for 34b84cc

• Change ItemUpdater#call to handle conjured items

  dkubb

  committed
  f4dac40

  Copy full SHA for f4dac40

• Add ItemUpdater#age

  Show description for f042bff
  dkubb

  committed
  f042bff

  Copy full SHA for f042bff

• Add ItemUpdater#value_change

  dkubb

  committed
  0926520

  Copy full SHA for 0926520

• Add ItemUpdater#change_quality

  dkubb

  committed
  e88ef77

  Copy full SHA for e88ef77

• Add SulfurasUpdater as a subclass of ItemUpdater

  Show description for 2107fbe
  dkubb

  committed
  2107fbe

  Copy full SHA for 2107fbe

• Add SulfurasUpdater#age

  Show description for a82912e
  dkubb

  committed
  a82912e

  Copy full SHA for a82912e

• Add SulfurasUpdater#change_quality

  Show description for 912377a
  dkubb

  committed
  912377a

  Copy full SHA for 912377a

• Add AgedBrieUpdaterUpdater as a subclass of ItemUpdater

  dkubb

  committed
  ec1016a

  Copy full SHA for ec1016a

• Add AgedBrieUpdater#value_change

  Show description for d6b8b70
  dkubb

  committed
  d6b8b70

  Copy full SHA for d6b8b70

• Add BackspacePassUpdater as a subclass of ItemUpdater

  dkubb

  committed
  bf624d4

  Copy full SHA for bf624d4

• Add BackspacePassUpdater#value_change

  Show description for 1b7ca2e
  dkubb

  committed
  1b7ca2e

  Copy full SHA for 1b7ca2e

• Add ConjuredUpdater as a subclass of ItemUpdater

  dkubb

  committed
  2a2a313

  Copy full SHA for 2a2a313

• Add ConjuredUpdater#value_change

  Show description for b66ef1a
  dkubb

  committed
  b66ef1a

  Copy full SHA for b66ef1a