Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to document all the meaningful changes from v2 to v1. I have skipped some as I am uncertain of their merit:
On windows the dub binary that comes with the compiler is no longer deleted when the user specifies the
dub:
parameter. I don't know why the old code was doing it but CI does pass without it. The relevant snippet of the old code:setup-dlang/src/main.ts
Lines 50 to 58 in 2979e3e
On arm64 macos, with ldc older then 1.30.0_beta1 (the first universal release) the only library directory that is added to
LD_LIBRARY_PATH
islib
, notlib-x86_64
orlib-arm64
. The old code is:setup-dlang/src/compiler.ts
Lines 289 to 313 in 2979e3e
lib-arm64
added toLD_LIBRARY_PATH
. Now I think that this is a mistake and that directory should be added but I want to confirm this first. ldc2 is configured to use that directory but since the actions says that it will be added toLD_LIBRARY_PATH
I want to be certain that this is the right thing to do.