Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the appearance of select boxes in VitePress/Altair embeddings #180

Merged

Conversation

WillHannon-MCB
Copy link
Collaborator

The select box wasn't visible in Altair plots embedded in VitePress. VitePress removes the browser-determined styling of select boxes so developers can design a custom appearance.

select {
    -webkit-appearance: none;
}

Explicitly specifying the select box's appearance is reasonable in a complex website, but the browser defaults are fine for us, so I overwrote the VitePress styles.

select {
    -webkit-appearance: auto;
}

@WillHannon-MCB WillHannon-MCB requested a review from jbloom January 2, 2025 22:07
@WillHannon-MCB WillHannon-MCB linked an issue Jan 2, 2025 that may be closed by this pull request
@WillHannon-MCB
Copy link
Collaborator Author

@jbloom, we also need to modify the styles in Bernadeta's repo to fix this issue.

I'll fix the issue if you give me permissions for that repo.

@Bernadetadad
Copy link

@WillHannon-MCB I gave you access

@jbloom jbloom merged commit 1ceab71 into main Jan 3, 2025
2 checks passed
@jbloom jbloom deleted the 176-issue-w-embedding-altair-plots-in-vitepress-homepage branch January 3, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue w embedding Altair plots in VitePress homepage
3 participants