[feat #186] 질문글 삭제 API #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Code Coverage
|
Test Results 28 files 28 suites 14s ⏱️ Results for commit aac0f2c. ♻️ This comment has been updated with latest results. |
dudxo
reviewed
Jan 5, 2025
src/main/java/com/dnd/gongmuin/question_post/service/QuestionPostService.java
Show resolved
Hide resolved
src/main/java/com/dnd/gongmuin/question_post/service/QuestionPostService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/gongmuin/question_post/service/QuestionPostService.java
Outdated
Show resolved
Hide resolved
src/test/java/com/dnd/gongmuin/question_post/service/QuestionPostServiceTest.java
Outdated
Show resolved
Hide resolved
dudxo
approved these changes
Jan 12, 2025
| } | ||
| } | ||
|
|
||
| private void validateIfQuestioner(Member member, QuestionPost questionPost){ |
|
|
||
| @DisplayName("[질문글 작성자가 아닌 경우 질문글을 삭제할 수 없다.]") | ||
| @Test | ||
| void deleteQuestionPostFails2() { |
There was a problem hiding this comment.
�예외 발생 추가 케이스에 대한 테스트 코드 좋네요👍
메서드명에 테스트 행위를 담으면 길어져서 오히려 가독성이 떨어진다고 생각했습니다! DisplayName으로 나타낼 수 있으니 간결하게 네이밍해도 괜찮을 것 같아요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분
refundClosedQuestionPosts()로 수정했습니다.