Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[# 206] 랜덤 일러스트레이터 표현 기능 구현 #209

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

gihwan-dev
Copy link
Collaborator

기능 구현은 완료했으나, 일러스트 사이즈 문제로 중앙 정렬이 힘듬. 현재는 기본 일러스트만 반환하도록 구현해뒀습니다. 일러스트 바닥에 붙여지면 수정하겠습니다!

What is this PR? 🔍

Changes 📝

Screenshot 📷

기능 구현은 완료했으나, 일러스트 사이즈 문제로 중앙 정렬이 힘듬. 현재는 기본 일러스트만 반환하도록 구현해둠.
@gihwan-dev gihwan-dev self-assigned this Sep 9, 2024
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dnd-11th-8-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 1:07pm
dnd-11th-8-frontend-rvo5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 1:07pm

@gihwan-dev
Copy link
Collaborator Author

gihwan-dev commented Sep 9, 2024

Test Coverage

[email protected] coverage /home/runner/work/dnd-11th-8-frontend/dnd-11th-8-frontend
vitest run --coverage

RUN v2.0.5 /home/runner/work/dnd-11th-8-frontend/dnd-11th-8-frontend
Coverage enabled with v8

src/test/utils/dateUtils.test.ts (4 tests) 4ms
src/test/utils/validation.test.ts (2 tests) 5ms
src/test/utils/SomeTest.test.tsx (1 test) 62ms
src/test/utils/sum.test.ts (1 test) 2ms

Test Files 4 passed (4)
Tests 8 passed (8)
Start at 13:07:08
Duration 3.86s (transform 84ms, setup 789ms, collect 68ms, tests 73ms, environment 2.00s, prepare 417ms)

% Coverage report from v8

=============================== Coverage summary ===============================

Statements   : 0.1% ( 9/8350 )
Branches     : 6.97% ( 18/258 )
Functions    : 5.51% ( 14/254 )
Lines        : 0.1% ( 9/8350 )
================================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 메인페이지 일러스트 랜덤 일러스트로 보여주도록 수정
1 participant