Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[# 228] 식물 물주기, 비료주기 추가 바텀 시트 오류 수정 #229

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

gihwan-dev
Copy link
Collaborator

What is this PR? 🔍

식물 물주기, 비료주기 추가 바텀 시트 값 선택했는데도 추천값이 사용된다는 다이얼로그가 발생하던 문제 해결

Changes 📝

  • 바텀시트의 CTA 버튼이 onClose 함수를 호출하는게 아닌 setIsOpen(false)를 호출하도록 변경

Screenshot 📷

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dnd-11th-8-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 4:51am
dnd-11th-8-frontend-rvo5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 4:51am

@gihwan-dev
Copy link
Collaborator Author

Test Coverage

[email protected] coverage /home/runner/work/dnd-11th-8-frontend/dnd-11th-8-frontend
vitest run --coverage

RUN v2.1.1 /home/runner/work/dnd-11th-8-frontend/dnd-11th-8-frontend
Coverage enabled with v8

src/test/utils/dateUtils.test.ts (4 tests) 4ms
src/test/utils/validation.test.ts (2 tests) 5ms
src/test/utils/SomeTest.test.tsx (1 test) 82ms
src/test/utils/sum.test.ts (1 test) 3ms

Test Files 4 passed (4)
Tests 8 passed (8)
Start at 04:51:38
Duration 3.93s (transform 83ms, setup 978ms, collect 59ms, tests 93ms, environment 2.03s, prepare 418ms)

% Coverage report from v8

=============================== Coverage summary ===============================

Statements   : 0.09% ( 9/9272 )
Branches     : 6.76% ( 19/281 )
Functions    : 5.41% ( 15/277 )
Lines        : 0.09% ( 9/9272 )
================================================================================

@gihwan-dev gihwan-dev merged commit 62ee7b3 into main Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 식물 등록 바텀 시트 처음 주기 입력해도 경고창이 나옴
1 participant