feat: unit-tests and it pre-commit hook

git-hooks/pre-commit.sh

@@ -0,0 +1,7 @@
+ #!/usr/bin/sh
+
+ go test -v ./...
+ if [ $? -ne 0 ]; then
+   echo "unit tests failed"
+   exit 1
+ fi

subnet/subnetContains.go

@@ -3,7 +3,6 @@ package subnet
 import (
 	"fmt"
 	"net"
-	"os"
 )
 
 func SubnetContains(args []string) bool {
@@ -13,7 +12,7 @@ func SubnetContains(args []string) bool {
 	_, ipv4Net, err := net.ParseCIDR(args[0])
 	if err != nil {
 		fmt.Println(err)
-		os.Exit(1)
+		return false
 	}
 
 	ipv4Addr := net.ParseIP(args[1])
@@ -22,7 +21,7 @@ func SubnetContains(args []string) bool {
 		_, ipv4Net2, err := net.ParseCIDR(args[1])
 		if err != nil {
 			fmt.Println(string(args[1]) + " is not recognized as IPv4 address nor a network")
-			os.Exit(1)
+			return false
 		}
 		// checking if subnet contains another subnet:
 		if subnetContainsSubnet(ipv4Net, ipv4Net2) {

tests/subnet_test.go

@@ -0,0 +1,54 @@
+package tests
+
+import (
+	"testing"
+	"github.com/docent-net/ipcalc-contains/subnet"
+)
+
+func TestSubnetContainsShouldFailUncrecognizedIPv4Network(t *testing.T) {
+	args := []string{"aaa", "192.168.123.0/30"}
+
+	if subnet.SubnetContains(args) != false {
+		t.Errorf("Expected %s to fail CIDR verification, but it did succeed", args[0])
+	}
+}
+
+func TestSubnetContainsShouldFailUncrecognizedIPv4(t *testing.T) {
+	args := []string{"192.168.1.0/20", "abc"}
+
+	if subnet.SubnetContains(args) != false {
+		t.Errorf("Expected %s to fail CIDR verification, but it did succeed", args[1])
+	}
+}
+
+func TestSubnetContainsNetworkShouldContainNetwork(t *testing.T) {
+	args := []string{"192.168.0.0/20", "192.168.12.0/30"}
+
+	if subnet.SubnetContains(args) != true {
+		t.Errorf("Expected %s to contain %s, but it failed", args[0], args[1])
+	}
+}
+
+func TestSubnetContainsNetworkShouldNotContainNetwork(t *testing.T) {
+	args := []string{"192.168.0.0/20", "192.168.128.0/30"}
+
+	if subnet.SubnetContains(args) != false {
+		t.Errorf("Expected %s to NOT contain %s, but it did", args[0], args[1])
+	}
+}
+
+func TestSubnetContainsNetworkShouldContainIPv4(t *testing.T) {
+	args := []string{"192.168.0.0/20", "192.168.12.123"}
+
+	if subnet.SubnetContains(args) != true {
+		t.Errorf("Expected %s to contain %s, but it failed", args[0], args[1])
+	}
+}
+
+func TestSubnetContainsNetworkShouldNotContainIPv4(t *testing.T) {
+	args := []string{"192.168.0.0/20", "10.0.0.12"}
+
+	if subnet.SubnetContains(args) != false {
+		t.Errorf("Expected %s to NOT contain %s, but it did", args[0], args[1])
+	}
+}