Patch for build with mock #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add fedora define Signed-off-by: eabdullin <[email protected]>
Signed-off-by: eabdullin <[email protected]>
|
@rumpl Hello, can you please review this change? |
|
@thaJeztah Maybe you can help? |
|
I'm not sure if we should make these changes; all the scripts and specs in this repository are currently designed to be used as part of the Dockerfiles in this repository; IIUC, these changes would mean that the distro-provided golang would be installed (not the version as specified in the |
|
Yes, with these changes will be used upstream version of golang from the current distro |
|
Should we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
During the build of Docker, I encountered the fact that it cannot be built using a mock. Changes in the PR allow you to build not from under the user's root, as well as use a mock.