Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cli docs #294

Merged
merged 4 commits into from
Sep 5, 2024
Merged

move cli docs #294

merged 4 commits into from
Sep 5, 2024

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Aug 19, 2024

Description
Move CLI docs to CLI repo

Review Instructions
n/a

Issue
dockstore/dockstore#5979

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Aug 19, 2024
@denis-yuen denis-yuen mentioned this pull request Aug 19, 2024
10 tasks
@denis-yuen denis-yuen changed the title move move cli docs Aug 19, 2024
@denis-yuen denis-yuen requested review from a team, david4096, kathy-t and hyunnaye and removed request for a team August 19, 2024 21:09
@denis-yuen denis-yuen marked this pull request as ready for review August 19, 2024 21:09
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (af86492) to head (d5db798).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #294      +/-   ##
=============================================
- Coverage      70.09%   70.07%   -0.02%     
+ Complexity      1059     1056       -3     
=============================================
  Files             47       47              
  Lines           6069     6069              
  Branches         801      801              
=============================================
- Hits            4254     4253       -1     
  Misses          1470     1470              
- Partials         345      346       +1     
Flag Coverage Δ
bitbuckettests 9.83% <ø> (ø)
confidentialtooltests 55.51% <ø> (-0.20%) ⬇️
confidentialworkflowtests 30.25% <ø> (ø)
nonconfidentialtests 32.36% <ø> (-0.05%) ⬇️
singularitytests 16.59% <ø> (ø)
unittests 8.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@david4096
Copy link
Member

Basically fine but the sentence will be a little awkward "you will be able to download the Dockstore CLI at https://dockstore.org/onboarding". Would suggest the link have a more descriptive title

@denis-yuen
Copy link
Member Author

Basically fine

actually, it was straight-up flipped, fixing

Copy link

sonarqubecloud bot commented Sep 5, 2024

@denis-yuen denis-yuen merged commit 8fd844f into develop Sep 5, 2024
16 checks passed
@denis-yuen denis-yuen deleted the feature/move_doc branch September 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants