Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix develop nightly builds #297

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix develop nightly builds #297

merged 4 commits into from
Nov 25, 2024

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Nov 22, 2024

Description
This fixes dockstore-cli compatibility with dockstore 1.17 webservice.
Breakage was in large part due to the riskier cwlavro clean-up we had been putting off and to a lesser degree, regular dependency updates in our bom

Review Instructions
Check if nightly develop builds are back on track after merge

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6808

Security
None

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Nov 22, 2024
@denis-yuen denis-yuen marked this pull request as ready for review November 22, 2024 21:45
@denis-yuen denis-yuen requested review from a team, coverbeck, david4096, hyunnaye and kathy-t and removed request for a team November 22, 2024 21:45
@denis-yuen denis-yuen changed the title Feature/fix develop fix develop nightly builds Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (d290680) to head (9789fd1).
Report is 37 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #297      +/-   ##
=============================================
- Coverage      70.22%   69.97%   -0.25%     
+ Complexity      1068     1054      -14     
=============================================
  Files             47       47              
  Lines           6069     6069              
  Branches         801      801              
=============================================
- Hits            4262     4247      -15     
- Misses          1466     1475       +9     
- Partials         341      347       +6     
Flag Coverage Δ
bitbuckettests 9.83% <0.00%> (ø)
confidentialtooltests 55.70% <100.00%> (-0.14%) ⬇️
confidentialworkflowtests 30.26% <100.00%> (+0.06%) ⬆️
nonconfidentialtests 32.29% <100.00%> (-0.10%) ⬇️
singularitytests 16.59% <50.00%> (ø)
unittests 8.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@denis-yuen
Copy link
Member Author

Oops, merge conflicted myself.

@denis-yuen denis-yuen merged commit f73108d into develop Nov 25, 2024
16 checks passed
@denis-yuen denis-yuen deleted the feature/fix_develop branch November 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants