-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reusable deploy artifacts workflow #298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #298 +/- ##
=============================================
- Coverage 70.36% 70.31% -0.05%
+ Complexity 1065 1059 -6
=============================================
Files 48 48
Lines 6073 6073
Branches 801 801
=============================================
- Hits 4273 4270 -3
Misses 1457 1457
- Partials 343 346 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending update to main branch.
|
Description
See dockstore/workflow-actions#3 for the reusable workflows used in this PR.
This PR combines the
tagged_release
anddeploy_snapshots
into one workflow calleddeploy_artifacts
that deploys either a tagged release or branch snapshot to artifactory (see https://github.com/dockstore/dockstore-cli/actions/workflows/deploy_artifacts.yml for examples of the runs). This creates snapshots for feature branches as well. Thedeploy_artifacts
is invoked on push of a tag or branch automatically so we no longer need to manually run the GitHub Action for a release.The
settings.xml
files are deleted because the settings are now specified in the reusabledeploy_artifacts
workflow.Review Instructions
Builds should pass for the develop branch. Create a new tagged release and verify that the
Deploy artifacts
GitHub action works.Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6771
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install