Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6000: Propagate both the "added" and "removed" varieties of the "installation_repositories" event #161

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

svonworl
Copy link
Contributor

@svonworl svonworl commented Mar 25, 2024

Description
This PR changes the upsertGitHub lambda to propagate both possible varieties of the "installation_repositories" event (wherein the action is either "added" or "removed") to the webservice.

Regarding the code style, it's not how I would have formatted/indented the code, but that's what our tests require.

Had remove the duplicate <repository> lines from that pom to make the tests pass.

After this PR merges, I will update dockstore-deploy to incorporate the corresponding commit.

Review Instructions
https://ucsc-cgl.atlassian.net/browse/SEAB-6000

Testing
See dockstore/dockstore#5852

Security
No concerns.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.

Copy link

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this require downtime when we install this version? I think so, we don't want 1.15 getting any of these events do we? And we don't want 1.16 getting any of the 1.15 formatted events?

If downtime is required, can you please update the 1.16 deploy notes.

@svonworl
Copy link
Contributor Author

svonworl commented Mar 27, 2024

Will this require downtime when we install this version? I think so, we don't want 1.15 getting any of these events do we? And we don't want 1.16 getting any of the 1.15 formatted events?

If downtime is required, can you please update the 1.16 deploy notes.

The previous lambda propagates installation_repositories events that contain an "added" action, this new lambda propagates all versions of the event. An event with an "added" action contains the affected repositories in the repositories_added field, which the old webservice inspects to figure out which repos got added. An event with a "removed" action should have an empty repositories_added field, so if such an event reaches the old webservice, I believe it's a no-op, so no downtime required.

@svonworl svonworl merged commit 3afb39f into develop Mar 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants