Use enum values from enumType in DiscriminatorColumn and check DiscriminatorMap values against it #11804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtFieldsWhereDeclared`
These new issues are caused by doctrine/common 3.5.0, released 2 weeks ago.
Ignore deprecations from doctrine/common
…clared Fix fields of transient classes being considered duplicate with `reportFieldsWhereDeclared`
Nullability is not inherited from the PHP type. The change that enabled this feature was reversed in doctrine#8732.
Fix invalid enum value in array of enums
|
I'm unsure where to go from here. It seems to me tests are failing on platforms with no native enum support. |
No, the tests are failing on DBAL versions without |
We should be using quoteSingleIdentifier(), assuming we only ever pass single identifiers here. See doctrine/dbal#6590
The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
…exed-relation 11783 failure with indexed relation
Address quoteIdentifier() deprecation
Bumps [doctrine/.github](https://github.com/doctrine/.github) from 7.1.0 to 7.2.1. - [Release notes](https://github.com/doctrine/.github/releases) - [Commits](doctrine/.github@7.1.0...7.2.1) --- updated-dependencies: - dependency-name: doctrine/.github dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…ions/2.20.x/doctrine/dot-github-7.2.1 Bump doctrine/.github from 7.1.0 to 7.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #11794.
Currently the values of enumType in DiscriminatorColumn are ignored which results in an error when generating a migration:
Fixed by populating values from the enum and also prevent invalid entries in DiscriminatorMap.