Clone query hints and parameters in LimitSubqueryOutputWalker constructor
#11826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprat84
force-pushed
the
gh-11741
branch
2 times, most recently
from
2ebf558 to
52b1cdb
Compare
SenseException
requested changes
Feb 6, 2025
tests/Tests/ORM/Tools/Pagination/LimitSubqueryOutputWalkerTest.php
Outdated
Show resolved
Hide resolved
…ctor This fixes a bug that arises when using Pagination and an entity relation is mapped with fetch-mode EAGER but setFetchMode LAZY (or anything that is not EAGER) has been used on the query. If the query use WITH condition, an exception is incorrectly raised (Associations with fetch-mode=EAGER may not be using WITH conditions). The class LimitSubqueryOutputWalker clones the query, but not its parameters and hints, so the generated subquery does not know that fetch-mode has been overridden. Fixes doctrine#11741
SenseException
approved these changes
Feb 11, 2025
greg0ire
approved these changes
Feb 12, 2025
|
Thanks @aprat84 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11741
Should be merged up to at least v2.20.0 and v3.3.0.
The problem seems to be that
LimitSubqueryOutputWalkerclones theQueryobject, but not its hints (including thefetchModehint, which causes the issue).Don't know if cloning the parameters is really needed.
Been inspired on what the class
Paginatordoes when cloning aQuery.Suggestions are welcome!