Skip to content
This repository has been archived by the owner on Sep 10, 2020. It is now read-only.

Bump cri from 2.9.1 to 2.15.10 #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link

Bumps cri from 2.9.1 to 2.15.10.

Release notes

Sourced from cri's releases.

2.15.10

Fixes:

  • Fixed warnings appearing in Ruby 2.7 (9a3d810)

2.15.9

Fixes:

  • Fixed bug which could cause options from one command appear in other commands (#101, #102)

2.15.8

Fixes:

  • Don’t explicitly set default values for options (#99)

This release reverts a backwards-incompatible change introduced in 2.15.7.

To illustrate this, compare the behavior of the following command in recent versions of Cri:

option :f, :force, 'use force', argument: :forbidden
run do |opts, args, cmd|
puts "Options = #{opts.inspect}"
puts "Force? #{opts[:force]}"
puts "Option given? #{opts.key?(:force)}"
end

In Cri 2.15.6, the default is not set in the options hash, so the value is nil and #key? returns false:

% ./run
Options = {}
Force? nil
Option given? false

This behavior was inconsistent with what was documented: flag options were (and still are) documented to default to false rather than nil.

In Cri 2.15.7, the default value is false, and explicitly set in the options hash (#key? returns true):

% ./run
Options = {:force=>false}
Force? false
Option given? true

This change made it impossible to detect options that were not explicitly specified, because the behavior of #key? also changed.

... (truncated)
Changelog

Sourced from cri's changelog.

2.15.10

Fixes:

  • Fixed warnings appearing in Ruby 2.7 (9a3d810)

2.15.9

Fixes:

  • Fixed bug which could cause options from one command appear in other commands (#101, #102)

2.15.8

Fixes:

  • Don’t explicitly set default values for options (#99)

This release reverts a backwards-incompatible change introduced in 2.15.7.

To illustrate this, compare the behavior of the following command in recent versions of Cri:

option :f, :force, 'use force', argument: :forbidden
run do |opts, args, cmd|
puts "Options = #{opts.inspect}"
puts "Force? #{opts[:force]}"
puts "Option given? #{opts.key?(:force)}"
end

In Cri 2.15.6, the default is not set in the options hash, so the value is nil and #key? returns false:

% ./run
Options = {}
Force? nil
Option given? false

This behavior was inconsistent with what was documented: flag options were (and still are) documented to default to false rather than nil.

In Cri 2.15.7, the default value is false, and explicitly set in the options hash (#key? returns true):

% ./run
Options = {:force=>false}
Force? false
Option given? true
</tr></table> ... (truncated)
Commits
  • cc1941a Add release notes for 2.15.10
  • d350613 Set version to 2.15.10
  • 9a3d810 Fix warnings on Ruby 2.7
  • d7cfbef Merge pull request #108 from bastelfreak/ruby
  • f33ad00 rubocop: fix Layout/SpaceAroundOperators
  • d60222a Add Ruby 2.7 to build matrix
  • 2f17267 Set version to 2.15.9
  • 4f6f5e2 Add release notes for 2.15.9
  • 705cc08 Merge pull request #102 from ddfreyne/fix-stray-option-definitions
  • e36dd77 Fix bug which causes option definitions to be merged
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jan 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants