-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and mimize build size #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the new webpack 5 features to separate the workers from the main package https://webpack.js.org/guides/web-workers/
The library is no longer bundled by webpack.
It provides the javascript compiled by tsc and the css compiled by tailwind.
Bundling and minimization should be done by the importer.
This allows optimization of dependencies on their end. (Eg otherwise all codemirror code was loaded twice in dodona)
I used file-loader instead of url-loader in order to not make the whole python zip inlined in javascript.
The scope of the serviceworker had to move to the root as some parts of the code are now served from /assets in dodona
To test the impact of these build changes I made a pr in dodona https://github.com/dodona-edu/dodona/pull/5204
As can be seen there, the changes here cause some required changes there.