This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
feat: add entity batching (n-02) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glihm
commented
Nov 5, 2024
Comment on lines
+694
to
+699
| let salt = core::poseidon::poseidon_hash_span( | ||
| [ | ||
| starknet::get_tx_info().unbox().transaction_hash, | ||
| dojo::utils::bytearray_hash(@namespace), | ||
| ].span() | ||
| ); |
There was a problem hiding this comment.
Here we want to support multi call, using the tx hash alone is not enough. Since we can't have 2 exact same classes in the same namespace, the hash of the namespace is added to the salt.
glihm
added a commit
that referenced
this pull request
Nov 11, 2024
* feat: add model upgradeability checks * fix: remove TODO since this code is no longer exposed in the plugin, hence can't be flatten at compile time * feat: add entity batching (n-02) (#32) * backport 1 * fix: fix contracts path * fix: missing merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.