Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev/katana branch #1697

Merged
merged 20 commits into from
Mar 26, 2024

fix(katana-executor): return reverted tx as error in estimate fee

0c67745
Select commit
Loading
Failed to load commit list.
Merged

Merge dev/katana branch #1697

fix(katana-executor): return reverted tx as error in estimate fee
0c67745
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 26, 2024 in 0s

62.33% (-5.77%) compared to 810b0f4

View this Pull Request on Codecov

62.33% (-5.77%) compared to 810b0f4

Details

Codecov Report

Attention: Patch coverage is 60.69029% with 1697 lines in your changes are missing coverage. Please review.

Project coverage is 62.33%. Comparing base (810b0f4) to head (0c67745).
Report is 3 commits behind head on main.

Files Patch % Lines
...es/katana/executor/src/implementation/sir/utils.rs 55.02% 273 Missing ⚠️
...na/executor/src/implementation/blockifier/utils.rs 63.31% 197 Missing ⚠️
crates/katana/rpc/rpc/src/starknet.rs 29.09% 156 Missing ⚠️
crates/saya/provider/src/rpc/transaction.rs 0.00% 132 Missing ⚠️
crates/katana/executor/src/implementation/noop.rs 17.75% 88 Missing ⚠️
crates/saya/provider/src/rpc/mod.rs 0.00% 88 Missing ⚠️
crates/katana/core/src/service/block_producer.rs 68.72% 76 Missing ⚠️
...na/executor/src/implementation/blockifier/state.rs 84.98% 68 Missing ⚠️
crates/katana/rpc/rpc-types/src/trace.rs 0.00% 58 Missing ⚠️
crates/katana/executor/src/abstraction/mod.rs 39.75% 50 Missing ⚠️
... and 44 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   68.09%   62.33%   -5.77%     
==========================================
  Files         273      295      +22     
  Lines       29509    33803    +4294     
==========================================
+ Hits        20095    21072     +977     
- Misses       9414    12731    +3317

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov