Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default invoke max steps #2395

Merged
merged 1 commit into from
Sep 8, 2024
Merged

update default invoke max steps #2395

merged 1 commit into from
Sep 8, 2024

Conversation

notV4l
Copy link
Collaborator

@notV4l notV4l commented Sep 8, 2024

Update default value to current limits https://docs.starknet.io/tools/limits-and-triggers/

Summary by CodeRabbit

  • New Features
    • Increased the maximum number of steps for invoke operations, enhancing system performance and capacity for complex transactions.

Copy link

coderabbitai bot commented Sep 8, 2024

Walkthrough

Ohayo, sensei! This pull request introduces a modification to the constant DEFAULT_INVOKE_MAX_STEPS, increasing its value from 1,000,000 to 10,000,000. This change affects the maximum number of steps allowed for invoke operations, while all other constants remain unchanged. The focus of this update is solely on the invoke step limit.

Changes

Files Change Summary
crates/katana/core/src/constants.rs Modified DEFAULT_INVOKE_MAX_STEPS from 1_000_000 to 10_000_000.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f8784c4 and 43d476a.

Files selected for processing (1)
  • crates/katana/core/src/constants.rs (1 hunks)
Additional comments not posted (1)
crates/katana/core/src/constants.rs (1)

9-9: Update to DEFAULT_INVOKE_MAX_STEPS approved.

The change from 1_000_000 to 10_000_000 aligns with the PR objectives to match the current limits specified in the StarkNet documentation. This adjustment should enhance the system's capability to handle more complex or resource-intensive transactions without hitting the previous limit.

Please ensure this update complies with the official StarkNet documentation. You might want to double-check the latest guidelines at https://docs.starknet.io/tools/limits-and-triggers/ to confirm that 10_000_000 is within the acceptable range.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.42%. Comparing base (f8784c4) to head (43d476a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2395   +/-   ##
=======================================
  Coverage   68.42%   68.42%           
=======================================
  Files         358      358           
  Lines       47328    47328           
=======================================
  Hits        32386    32386           
  Misses      14942    14942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notV4l notV4l requested a review from kariy September 8, 2024 15:35
@glihm glihm merged commit 28d843f into main Sep 8, 2024
15 checks passed
@glihm glihm deleted the invoke_max_steps branch September 8, 2024 19:48
@kariy kariy mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants