Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt(torii-core): move off queryqueue for executing tx #2460
opt(torii-core): move off queryqueue for executing tx #2460
Changes from 1 commit
01ce338
e0ec767
6097a60
043f669
9d7d0e7
9314438
f9a136f
b883343
7771fdf
60c9069
cd52f0f
045eed0
045e4ae
388ba1e
b7acef5
b94ad7a
c13ff59
7fc27d5
260845c
a7e4f1f
8cf4452
2bcf226
3242ac4
ef3e4ba
299c0b9
e4404f1
663234a
c998428
994abc5
65612fa
13b1ba7
0c31327
afa2a0a
ef9fafc
4ec379c
d393896
1730bfc
b708081
7758cf9
607cd06
d48dd30
6d4b99f
baf7f35
c4f288a
5dac220
28633b4
fd3c377
4cabea5
ee86042
43246b6
706c7fb
9c9e0a3
6b6f5a6
61f0a4b
63cca75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify entity deletion logic for clarity.
Ohayo, sensei! The conditionals around deleting entities when all models are deleted could be streamlined for better readability. Refactoring this logic can make the code more maintainable.
Consider this refactored snippet:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider asynchronous message publishing.
Ohayo, sensei! To improve performance, especially under heavy load, you might consider publishing broker messages asynchronously.
Here's how you could modify the loop: