Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm useless #[allow(deprecated)] #2519

Merged
merged 1 commit into from
Oct 11, 2024
+0 −6
Merged

rm useless #[allow(deprecated)] #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions crates/dojo-test-utils/src/sequencer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ pub struct TestSequencer {
}

impl TestSequencer {
#[allow(deprecated)]
pub async fn start(config: Config) -> Self {
let handle = katana_node::build(config)
.await
Expand Down Expand Up @@ -81,7 +80,6 @@ impl TestSequencer {
&self,
index: usize,
) -> SingleOwnerAccount<JsonRpcClient<HttpTransport>, LocalWallet> {
#[allow(deprecated)]
let accounts: Vec<_> =
self.handle.node.backend.chain_spec.genesis.accounts().collect::<_>();

Expand Down
1 change: 0 additions & 1 deletion crates/katana/rpc/rpc/src/dev.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ impl<EF: ExecutorFactory> DevApiServer for DevApi<EF> {
Ok(())
}

#[allow(deprecated)]
async fn predeployed_accounts(&self) -> Result<Vec<Account>, Error> {
Ok(self.backend.chain_spec.genesis.accounts().map(|e| Account::new(*e.0, e.1)).collect())
}
Expand Down
1 change: 0 additions & 1 deletion crates/katana/rpc/rpc/src/starknet/read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,6 @@ impl<EF: ExecutorFactory> StarknetApiServer for StarknetApi<EF> {

// If the node is run with transaction validation disabled, then we should not validate
// transactions when estimating the fee even if the `SKIP_VALIDATE` flag is not set.
#[allow(deprecated)]
let should_validate = !(skip_validate
|| this.inner.backend.executor_factory.execution_flags().skip_validate);
let flags = katana_executor::SimulationFlag {
Expand Down
2 changes: 0 additions & 2 deletions crates/katana/rpc/rpc/src/starknet/trace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,11 @@ impl<EF: ExecutorFactory> StarknetApi<EF> {

// If the node is run with transaction validation disabled, then we should not validate
// even if the `SKIP_VALIDATE` flag is not set.
#[allow(deprecated)]
let should_validate = !(simulation_flags.contains(&SimulationFlag::SkipValidate)
|| self.inner.backend.executor_factory.execution_flags().skip_validate);

// If the node is run with fee charge disabled, then we should disable charing fees even
// if the `SKIP_FEE_CHARGE` flag is not set.
#[allow(deprecated)]
let should_skip_fee = !(simulation_flags.contains(&SimulationFlag::SkipFeeCharge)
|| self.inner.backend.executor_factory.execution_flags().skip_fee_transfer);

Expand Down
Loading