Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devcontainer): update image: ebcc23d #2728

Closed
wants to merge 1 commit into from
+11 −11
Closed

chore(devcontainer): update image: ebcc23d #2728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// https://github.com/microsoft/vscode-dev-containers/tree/v0.245.2/containers/rust
{
"name": "Rust",
"image": "ghcr.io/dojoengine/dojo-dev:v1.0.2",
"image": "ghcr.io/dojoengine/dojo-dev:ebcc23d",
"runArgs": [
"--cap-add=SYS_PTRACE",
"--security-opt",
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
bench-katana:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
steps:
- uses: actions/checkout@v3
- run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
Expand All @@ -36,7 +36,7 @@ jobs:
bench-sozo:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
steps:
- uses: actions/checkout@v3
- run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
needs: ensure-docker
runs-on: ubuntu-latest-32-cores
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Ohayo sensei! The Docker image tag exists but needs updating

The ebcc23d tag exists in the container registry but appears to be an older tag, as evidenced by its position in the chronological list of tags. The latest stable version is v1.0.2. Consider using the latest stable version instead of a commit hash for better version tracking and maintainability.

  • Replace ghcr.io/dojoengine/dojo-dev:ebcc23d with ghcr.io/dojoengine/dojo-dev:v1.0.2 in the following files:
    • .github/workflows/ci.yml (lines 34, 59, 126, 142, 157, 166, 175)
🔗 Analysis chain

Ohayo sensei! Verify the Docker image version change

The image version has been changed from a semantic version to a commit hash (ebcc23d) across multiple jobs. While this ensures precise version pinning, it might make version tracking less intuitive.

Also applies to: 59-59, 126-126, 142-142, 157-157, 166-166, 175-175

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify if the Docker image exists and is accessible
docker pull ghcr.io/dojoengine/dojo-dev:ebcc23d 2>/dev/null
if [ $? -eq 0 ]; then
    echo "✓ Image exists and is accessible"
else
    echo "✗ Image not found or not accessible"
fi

# Check image details
docker inspect ghcr.io/dojoengine/dojo-dev:ebcc23d 2>/dev/null | jq '.[0].Created'

Length of output: 223

Script:

#!/bin/bash
# Let's check the GitHub Container Registry for available tags
gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /orgs/dojoengine/packages/container/dojo-dev/versions --paginate | jq -r '.[].metadata.container.tags[]' 2>/dev/null

# Also check the workflow file history to see when this image tag was introduced
git log -p --no-merges -S "ghcr.io/dojoengine/dojo-dev:ebcc23d" -- .github/workflows/ci.yml

Length of output: 4939

steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand All @@ -56,7 +56,7 @@ jobs:
ensure-wasm:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
needs: build
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
steps:
- uses: actions/download-artifact@v4
with:
Expand All @@ -139,7 +139,7 @@ jobs:
needs: build
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
steps:
- uses: actions/download-artifact@v4
with:
Expand All @@ -154,7 +154,7 @@ jobs:
clippy:
runs-on: ubuntu-latest-4-cores
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand All @@ -163,7 +163,7 @@ jobs:
fmt:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand All @@ -172,7 +172,7 @@ jobs:
docs:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-dispatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
contents: write
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.2
image: ghcr.io/dojoengine/dojo-dev:ebcc23d
env:
VERSION: ""
steps:
Expand Down
Loading