Prepare release: v1.0.3 #2735
Prepare release: v1.0.3 #2735
Conversation
WalkthroughOhayo, sensei! This pull request introduces updates primarily focused on versioning and dependency management across several Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Cargo.toml (1)
Line range hint
273-273: Consider using full git revision for slot dependency, sensei!While pinning to a specific git revision is good practice, using a short revision (1298a30) could potentially lead to ambiguity if multiple commits share the same prefix. Consider using the full SHA-1 hash for better reproducibility.
-slot = { git = "https://github.com/cartridge-gg/slot", rev = "1298a30" } +slot = { git = "https://github.com/cartridge-gg/slot", rev = "1298a30..." } # Replace with full SHA-1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (4)
Cargo.lockis excluded by!**/*.lockcrates/dojo/core/Scarb.lockis excluded by!**/*.lockcrates/torii/types-test/Scarb.lockis excluded by!**/*.lockexamples/spawn-and-move/Scarb.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
Cargo.toml(1 hunks)crates/dojo/core/Scarb.toml(1 hunks)crates/dojo/types/Cargo.toml(1 hunks)crates/torii/types-test/Scarb.toml(1 hunks)examples/spawn-and-move/Scarb.toml(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- crates/dojo/core/Scarb.toml
- crates/dojo/types/Cargo.toml
- crates/torii/types-test/Scarb.toml
- examples/spawn-and-move/Scarb.toml
🔇 Additional comments (2)
Cargo.toml (2)
61-61: Ohayo sensei! Version bump looks good!
The version increment from 1.0.2 to 1.0.3 follows semantic versioning and aligns with the release preparation.
Line range hint 248-249: Ohayo! Let's verify the IPFS dependency requirement, sensei!
There's an unresolved TODO about checking if the git version of ipfs-api-backend-hyper is still needed. Consider verifying if:
- The published crate version now includes the required features
- The custom git dependency is still necessary
✅ Verification successful
Ohayo! The git dependency is still necessary, sensei!
After checking the published version (0.6.0) and comparing it with the git dependency, it appears the custom git version is still required because:
- The project uses specific features (
with-hyper-rustls,with-send-sync) in the workspace - The git dependency is referenced with a specific commit (
af2c17f7b19ef5b9898f458d97a90055c3605633) - Multiple crates in the workspace depend on this specific version with custom features
The TODO can be resolved by keeping the git dependency as it's actively used across the codebase with specific feature requirements.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check latest published version and features
curl -s https://crates.io/api/v1/crates/ipfs-api-backend-hyper | jq -r '.crate.max_version, .crate.features'
Length of output: 121
Script:
#!/bin/bash
# Let's check the actual dependency in Cargo.toml
rg "ipfs-api-backend-hyper" -A 3 -B 3
# Also check for any TODO comments related to this dependency
rg -i "todo.*ipfs"
Length of output: 3320
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2735 +/- ##
==========================================
- Coverage 56.48% 56.47% -0.02%
==========================================
Files 421 421
Lines 53976 53976
==========================================
- Hits 30488 30482 -6
- Misses 23488 23494 +6 ☔ View full report in Codecov by Sentry. |
Co-authored-by: glihm <[email protected]>
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Updates
1.0.2to1.0.3across multiple components.slot) sourced from a Git repository.Bug Fixes
Chores
Cargo.tomlfiles, including the addition of newline characters.