chore(devcontainer): update image: v1.0.4 #2758
Conversation
WalkthroughOhayo, sensei! This pull request primarily updates the Docker image version across several configuration files used in a Rust development environment. The image version has been incremented from Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/ci.yml (1)
Line range hint
183-203: Great addition of Hurl API testing! Consider a small enhancement 🎋The Hurl test integration is excellent, but consider adding a timeout to the Katana startup wait.
Here's a suggested enhancement:
- nohup /tmp/bins/katana --dev --dev.accounts 2 --dev.no-fee & + nohup /tmp/bins/katana --dev --dev.accounts 2 --dev.no-fee & + KATANA_PID=$! + # Wait up to 30 seconds for Katana to start + for i in {1..30}; do + if curl -s http://localhost:5050 >/dev/null; then + break + fi + if ! kill -0 $KATANA_PID 2>/dev/null; then + echo "Katana failed to start" + exit 1 + fi + sleep 1 + done🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
.devcontainer/devcontainer.json(1 hunks).github/workflows/bench.yml(2 hunks).github/workflows/ci.yml(7 hunks).github/workflows/release-dispatch.yml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .devcontainer/devcontainer.json
- .github/workflows/release-dispatch.yml
🔇 Additional comments (4)
.github/workflows/bench.yml (1)
17-17: Ohayo sensei! LGTM on the image version updates! 🎋
The Docker image version has been consistently updated to v1.0.4 across both benchmark jobs.
Let's verify the image availability and changelog:
Also applies to: 39-39
✅ Verification successful
Ohayo sensei! The Docker image is verified and ready to roll! 🎋
The dojo-dev:v1.0.4 image exists in the GitHub Container Registry and is also tagged as latest, indicating it's the most current recommended version. The image was published on December 3rd, 2024, and is actively maintained.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the Docker image exists and fetch its details
gh api \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/orgs/dojoengine/packages/container/dojo-dev/versions \
| jq '.[] | select(.metadata.container.tags[] == "v1.0.4")'
Length of output: 810
.github/workflows/ci.yml (3)
34-34: Ohayo! Docker image version updates look consistent across all jobs! 🎋
The image version has been updated to v1.0.4 uniformly across all jobs that use the container.
Also applies to: 59-59, 126-126, 142-142, 157-157, 166-166, 175-175
Line range hint 17-25: Nice improvement to binary artifact management, sensei! 🎋
The new approach of creating a bins directory and uploading artifacts improves CI efficiency by avoiding redundant builds.
🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
Line range hint 93-106: Excellent addition of Docker health check! 🎋
The new health check in ensure-docker job adds reliability by verifying that Katana starts correctly in the minimal environment.
Let's verify the minimal dependencies in the base image:
✅ Verification successful
Let me verify the dependencies and binary requirements for Katana to ensure the minimal Debian image is sufficient.
Ohayo sensei! Based on the comprehensive analysis of the codebase, I can verify the health check implementation.
The minimal Debian image is sufficient for running Katana 🎋
The health check in the CI workflow is properly implemented and the base image debian:bookworm-slim has all the necessary dependencies since:
- The Dockerfile shows that Katana only requires basic system utilities that are included in the slim image by default
- The health check simply verifies process startup using standard Unix tools (
kill -0) - No additional runtime dependencies are required beyond what's in the base image
The workflow correctly validates that Katana can start and run in a minimal environment.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check minimal image dependencies
rg -l "FROM debian:bookworm-slim" | while read -r file; do
echo "Found in: $file"
rg "RUN apt-get (install|update)" "$file" -A 5
done
Length of output: 386
Script:
#!/bin/bash
# Let's check if there are any direct dependencies in the workflow file itself
rg "apt-get|apt install|apk add|yum install" .github/workflows/ci.yml
# Also check what binaries the katana process might need
rg -g "!{node_modules,dist,build}/*" "katana.*depends|katana.*requires" .
Length of output: 216
Script:
#!/bin/bash
# Check if there are any documented system requirements
fd "README|INSTALL|REQUIREMENTS" --type f --exec cat {}
Length of output: 33995
🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
=======================================
Coverage 54.69% 54.69%
=======================================
Files 427 427
Lines 53918 53918
=======================================
Hits 29490 29490
Misses 24428 24428 ☔ View full report in Codecov by Sentry. |
Update devcontainer image: v1.0.4 Co-authored-by: glihm <[email protected]>
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
test-hurljob to run tests with thehurltool.binsdirectory for binaries.Bug Fixes
katanaprocess.Chores