Fix vhost file value #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dokku takes base host for applications from VHOST file. This file contains hostname of operation system by default (`ubuntu` in my case). I fixed the value of `VHOST` with `dokku_hostname` variable.
|
@ltalirz does this seem good to merge? |
ltalirz
approved these changes
Apr 2, 2020
|
Debian install scripts should set initial values to config files and shouldn't update this files in next times I think. Config files can be edited by users later. In Ansible we want to update settings by changing a playbook. So values from playbook should always update files on the machine. |
|
Can we merge it? |
|
I wanted to let @josegonzalez do the merge. |
|
Seems mergeable. If someone wants to file an issue for upstream as well, that would be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dokku takes base host for applications from
VHOSTfile. This file contains hostname of operation system by default (ubuntuin my case). I fixed the value ofVHOSTwithdokku_hostnamevariable.May be related to #19
P. S. Tested with Ubuntu 18.04