This repository has been archived by the owner on Oct 28, 2020. It is now read-only.
Fixed the correct initial calculation of the offset. #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FrankMerema thanks for this PR. I will think about this update. |
|
Just a note from me, with this fix everything works fine in IE11 for me. |
|
@yowainwright Any thoughts on this PR already? |
|
@FrankMerema I'll look into this today. Sorry for the wait. |
yowainwright
approved these changes
Mar 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
It fixes for my project the issues with the initial calculation of the offsets
Proposed Changes
Initial stickyStart calculation
Offset used for sticky state, is the offset calculated in the computeScrollOffsets function
Resolves #455