feat: Added disclaimer for branch checkout #8957
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsehn
reviewed
Mar 7, 2025
There was a problem hiding this comment.
This needs to be a bit more robust.
Also we need a BATS test in:
https://github.com/dolthub/dolt/blob/main/integration-tests/bats/sql-checkout.bats
Some of those tests will need to be updated because we use dolt sql -q "call dolt_checkout('-b', ...)" a bunch of places.
| @@ -176,6 +178,10 @@ func doDoltCheckout(ctx *sql.Context, args []string) (statusCode int, successMes | |||
| if err != nil { | |||
| return 1, "", err | |||
| } | |||
| terminal_command:=strings.Join(os_args, " ") | |||
There was a problem hiding this comment.
I think we need to be a bit more clever here. I think we need to check and make sure that call dolt_checkout() with the -b option is the only sql statement being run.
There was a problem hiding this comment.
@timsehn
Okay but what if the user calls the command like dolt sql --q "call dolt_checkout('myBranch2');" i.e. without the -b option.
I believe this also needs to be handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #6876