Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/nbs: s3_object_reader: Fix a regression which prevented loading large table files with the AWS NomsBlockStore backend. #8963

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

store/nbs: s3_object_reader: Fix a regression which prevented loading large table files with the AWS NomsBlockStore backend. #8963

wants to merge 2 commits into from
+55 −13

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Mar 8, 2025

Affects 1.50.0, 1.50.1 and 1.50.2.

@reltuk
store/nbs: s3_object_reader: Fix a regression which prevented loading…
d1a76fb 
… large table files with the AWS NomsBlockStore backend.

Affects 1.50.0, 1.50.1 and 1.50.2.
@reltuk reltuk marked this pull request as ready for review March 8, 2025 02:07
@reltuk reltuk requested a review from macneale4 March 8, 2025 02:09
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d1a76fb ok 5937457
version total_tests
d1a76fb 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2812d02 ok 5937457
version total_tests
2812d02 5937457
correctness_percentage
100.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macneale4 macneale4 Awaiting requested review from macneale4

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reltuk @coffeegoddd