New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic when comparing system set type against other types #2842

Merged

jycor merged 1 commit into main from james/set

Feb 5, 2025

+8 −4

Contributor

jycor commented Feb 5, 2025 •

edited

Loading

Comparison between systemSetTypes and other types is still not correct.
It appears that MySQL actually treats @@sql_mode as just a string.

This PR only fixes the panic


          fix panic

417bf96

fulghum approved these changes

View reviewed changes

jycor mentioned this pull request

Incorrect results when comparing types.systemSetType against other types dolthub/dolt#8825

Open

jycor merged commit ace3b04 into main

9 checks passed

jycor deleted the james/set branch

February 5, 2025 23:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet