Git based dependencies #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominykas
force-pushed
the
git-based-deps
branch
from
9bd5790 to
dd110ae
Compare
dominykas
force-pushed
the
git-based-deps
branch
12 times, most recently
from
3c2bc94 to
cd38480
Compare
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: Jeff Valore <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]> add license headers for gitutils Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
See helm/community#321 Signed-off-by: Dominykas Blyžė <[email protected]>
Signed-off-by: Dominykas Blyžė <[email protected]>
Addresses helm#11258 (comment) Signed-off-by: Dominykas Blyžė <[email protected]>
Addresses helm#11258 (comment) Signed-off-by: Dominykas Blyžė <[email protected]>
Addresses helm#11258 (comment) Addresses helm#11258 (comment) Signed-off-by: Dominykas Blyžė <[email protected]>
See helm/community#321 Signed-off-by: Dominykas Blyžė <[email protected]>
Addresses helm#11258 (comment) Signed-off-by: Dominykas Blyžė <[email protected]>
Signed-off-by: Dominykas Blyžė <[email protected]>
Signed-off-by: Dominykas Blyžė <[email protected]>
This is to minimize the risk of credential leaks, see discussion: helm/community#321 (comment) Signed-off-by: Dominykas Blyžė <[email protected]>
Signed-off-by: Dominykas Blyžė <[email protected]>
Signed-off-by: Dominykas Blyžė <[email protected]>
dominykas
force-pushed
the
git-based-deps
branch
2 times, most recently
from
503a0ca to
3ad7c79
Compare
Avoids passing in an unnecessary param. Addresses helm#11258 (comment) Signed-off-by: Dominykas Blyžė <[email protected]>
…hart Addresses helm#11258 (comment) Addresses helm#11258 (comment) Signed-off-by: Dominykas Blyžė <[email protected]>
This should allow the code to be cleaner by encapsulating the behaviors inside individual getters. This is what pip and npm do too: - https://github.com/npm/npm-package-arg/blob/207ba7d5cf32c6daa4fd2aad644e8371dd33e0de/lib/npa.js#L340 - https://github.com/pypa/pip/blob/50e3c500bd2b27dd72317cfd5ff5bb498540e416/src/pip/_internal/vcs/git.py#L64C1-L64C1 Signed-off-by: Dominykas Blyžė <[email protected]>
This will make it easier to extend the functionality to be able to use subdirectories for charts Signed-off-by: Dominykas Blyžė <[email protected]>
Signed-off-by: Dominykas Blyžė <[email protected]>
dominykas
force-pushed
the
git-based-deps
branch
from
3ad7c79 to
46dfe59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(wip)
Changes
main, while discarding the two latest commits (which only seem to be touchinggo.mod/go.sum, i.e. the rebase would have addressed those).gofmtwhere missingTodo
ResolveChartVersionkeep the git URL intact and leave it up to the downloader to normalize it?fileutilwithchart.Save()?