Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some code quality issues #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pnijhara
Copy link

  • Remove unused variables
  • Fix dangerous default argument
  • Use literal syntax instead of function calls to create the data structure

Find the other issues found here - https://deepsource.io/gh/pnijhara/gitsome/issues/?category=all

This PR also adds .deepsource.toml configuration file to run DeepSource analysis on the repo with. Upon enabling DeepSource, the analysis will run on every PR and commit to detect 560+ types of issues in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.

To enable DeepSource analysis after merging this PR, please follow these steps:

  1. Signup on DeepSource with your GitHub account and grant access to this repo.
  2. Activate analysis on this repo here.

You can also look at the docs for more details. Do let me know if I can be of any help!

@codecov-io
Copy link

Codecov Report

Merging #176 into master will decrease coverage by 41.89%.
The diff coverage is 42.85%.

@@             Coverage Diff             @@
##           master     #176       +/-   ##
===========================================
- Coverage   95.09%   53.19%   -41.90%     
===========================================
  Files          34       86       +52     
  Lines        2119     6593     +4474     
===========================================
+ Hits         2015     3507     +1492     
- Misses        104     3086     +2982     

@Watemlifts
Copy link

Code quality fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants