Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the range of supported Ruby versions #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naitoh
Copy link
Contributor

@naitoh naitoh commented Jan 17, 2025

Ruby 3.4 is out

1. concurrent-ruby 1.3.5 don't work on Rails 7.0

NameError:
uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger

See: ruby-concurrency/concurrent-ruby#1062

2. concurrent-ruby 1.3.4 don't work on Ruby head

LoadError:
cannot load such file -- logger

Exclude the combination of Ruby head and Rails 7.0

This is a follow-up to what I have committed to doorkeeper gem in doorkeeper-gem/doorkeeper#1760.
I guess it would be great if the CI setup mirrors what doorkeeper has just like #215 has achieved it.

## Ruby 3.4 is out
### 1. concurrent-ruby 1.3.5 don't work on Rails 7.0

> NameError:
>  uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger

See: ruby-concurrency/concurrent-ruby#1062
@naitoh naitoh force-pushed the add-ruby-3.4-to-testing-matrix branch from 7abb9c2 to a7990d9 Compare January 17, 2025 14:05
@naitoh naitoh changed the title Test against Ruby 3.4. Bump the range of supported Ruby versions Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant