Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit FURB120 when deleting default arg would change semantics #289

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Don't emit FURB120 when deleting default arg would change semantics #289

merged 1 commit into from
Sep 12, 2023

Commits on Sep 12, 2023

  1. Don't emit FURB120 when deleting default arg would change semantics: 

    Closes #288.

Previously FURB120 would emit an error for any default arg it found, but in
some cases following Refurb's advice would cause an error. The issue is that
non-default positional args that follow default positional args cannot be
removed, so Refurb should ignore these default values that are "trapped" behind
a non-default one.
    @dosisod
    dosisod committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3eb61eb View commit details
    Browse the repository at this point in the history