Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

222: add contributors field on snippet #231

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

jjcantu
Copy link
Contributor

@jjcantu jjcantu commented Jan 12, 2025

Description

Added a contributors field on snippets in the front-end

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe): New contributors field on front end

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #222

Additional Context

Screenshots (Optional)

Click to view screenshots image image

@jjcantu
Copy link
Contributor Author

jjcantu commented Jan 12, 2025

I think this is a good temporary fix, later down the line we can add a tooltip to display all the contributors. Let me know what you guys think.

@jjcantu
Copy link
Contributor Author

jjcantu commented Jan 12, 2025

@Mathys-Gasnier I do not have write access but this is ready to be merged.

@dostonnabotov
Copy link
Owner

Hey, there. Thanks for the fix.

I think this is a good temporary fix, later down the line we can add a tooltip to display all the contributors.

Yeah, as the number of contributors increases, we can opt for a different solution. For now, it looks good to me.

@dostonnabotov dostonnabotov merged commit 88d7805 into dostonnabotov:main Jan 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Contributors field for frontend
3 participants