Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snippets-C++] fix a snippets and update another. #234

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

majvax
Copy link
Collaborator

@majvax majvax commented Jan 13, 2025

Description

Find-non-repeating-number

  • Fixed a missing lib
  • Fixed const-correctness

Binary-to-decimal-conversion

  • Adapted it to c++ as it wasn't using any c++ features.
  • Fix few problem related to integer size, using c++20 concept, now support only unsigned integral type and up to 64bit long string

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

@majvax majvax requested a review from saminjay as a code owner January 13, 2025 13:52
@majvax majvax added mergeable Reviewed and ready to be merged Snippets labels Jan 17, 2025
@Mathys-Gasnier Mathys-Gasnier merged commit fde22e6 into dostonnabotov:main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeable Reviewed and ready to be merged Snippets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants