Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute human-date.md #244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Yuvaraja28
Copy link

Contributing Human readable Date format

Description

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

Contributing Human readable Date format
Copy link
Collaborator

@majvax majvax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thanks for your contribution !πŸ™Œ
However, your title doesn't match the name of the file, It should be Human Date or you can do the opposite and rename the file human-readable-date. See other snippets for reference.

Please read CONTRIBUTION.md carefully.

I think you should add a locale argument to format date to other country standard like fr-FR that default to en-US.

@Yuvaraja28
Copy link
Author

Changed to comply with the Contribution Rules

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this looks more like an example on how to use the js date formatter than a snippet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants