Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use extensions.code to specify errors #3672

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jan 16, 2025

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: f0c10bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
graphql-yoga Minor
@graphql-yoga/nestjs Major
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/apollo-managed-federation Major
@graphql-yoga/plugin-apollo-usage-report Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-csrf-prevention Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-disable-introspection Major
@graphql-yoga/plugin-graphql-sse Major
@graphql-yoga/plugin-jwt Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Jan 16, 2025

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 524076      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 105 MB  702 kB/s
     http_req_blocked.............................: avg=1.53µs   min=1.04µs   med=1.35µs   max=282.06µs p(90)=2.01µs   p(95)=2.19µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=155.41µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=354.65µs min=215.73µs med=323.15µs max=18.68ms  p(90)=466.39µs p(95)=487.16µs
       { expected_response:true }.................: avg=354.65µs min=215.73µs med=323.15µs max=18.68ms  p(90)=466.39µs p(95)=487.16µs
     ✓ { mode:graphql-jit }.......................: avg=283µs    min=215.73µs med=266.66µs max=18.68ms  p(90)=297.36µs p(95)=311.66µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=489.69µs min=408.65µs med=468.46µs max=6.05ms   p(90)=506.9µs  p(95)=548.37µs
     ✓ { mode:graphql-response-cache }............: avg=339.59µs min=262.75µs med=323.67µs max=6.81ms   p(90)=352.36µs p(95)=362.38µs
     ✓ { mode:graphql }...........................: avg=361.24µs min=274.64µs med=332.44µs max=13.94ms  p(90)=388.4µs  p(95)=441.98µs
     ✓ { mode:uws }...............................: avg=337.9µs  min=268.86µs med=321.1µs  max=5.89ms   p(90)=355.56µs p(95)=377.3µs 
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 262038
     http_req_receiving...........................: avg=32.86µs  min=16.3µs   med=32.48µs  max=3.24ms   p(90)=39.09µs  p(95)=41.47µs 
     http_req_sending.............................: avg=8.58µs   min=5.9µs    med=7.54µs   max=338.74µs p(90)=10.98µs  p(95)=11.94µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=313.2µs  min=182µs    med=282.63µs max=18.58ms  p(90)=424.25µs p(95)=443.38µs
     http_reqs....................................: 262038  1746.901565/s
     iteration_duration...........................: avg=567.45µs min=384.77µs med=531.45µs max=19.23ms  p(90)=684.15µs p(95)=709.15µs
     iterations...................................: 262038  1746.901565/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Copy link
Contributor

github-actions bot commented Jan 16, 2025

💻 Website Preview

The latest changes are available as preview in: https://040b0d43.graphql-yoga.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant