views/pods: use wildcard for all option in pod variable
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pod` variable could contain thousands of options in some environments. Selecting `all` options would mean dashboard will include all of them into the PromQL query and potentially cause issues on processing. Switching to wildcard `.*` instead will prevent sending huge queries to database and dashboard will continue to work for any environment. See dotdc#129
dotdc
approved these changes
Nov 26, 2024
|
🎉 This PR is included in version 2.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dotdc
added a commit
that referenced
this pull request
Nov 26, 2024
Signed-off-by: David Calvert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Required Fields
🔎 What kind of change is it?
🎯 What has been changed and why do we need it?
podvariable could contain thousands of options in some environments. Selectingalloptions would mean dashboard will include all of them into the PromQL query and potentially cause issues on processing.Switching to wildcard
.*instead will prevent sending huge queries to database and dashboard will continue to work for any environment.Optional Fields
✔️ Which issue(s) this PR fixes?
fixes #129