Update k8s-system-api-server.json #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the ability to view the metrics for kubernetes clusters and server api nodes separately, as this adds more visibility
|
i can do the same for other dashboards |
dotdc
requested changes
Jul 20, 2023
There was a problem hiding this comment.
Thank you for submitting this PR, unfortunately, there are a few issues right now :
- your base version is old, and you revert a lot of changes
- you remove useful information like __inputs
- you add instance specific information from your setup (hardcoded uid, id, gneid...)
- there are several changes in this PR, and it's unclear what the goal is.
If the goal was to fix #15, I think you should read the issue again. The cluster variable is not universal, and I don't want to make it a prerequisite for this project.
Like mentioned before, a script that could generate and inject that in the dashboards would be good for users who cannot rely on Grafana datasources to manage their clusters.
I will explain the workaround in the documentation to make things more clear.
|
okay i will clouse the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to view the metrics for kubernetes clusters and server api nodes separately, as this adds more visibility