Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: diff operation #132

Merged
merged 6 commits into from
Feb 16, 2024
Merged

feat: diff operation #132

merged 6 commits into from
Feb 16, 2024

Conversation

nadilas
Copy link
Member

@nadilas nadilas commented Feb 15, 2024

No description provided.

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ogre ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2024 5:40pm

@nadilas
Copy link
Member Author

nadilas commented Feb 15, 2024

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8d4a177) 80.93% compared to head (a07c233) 76.49%.
Report is 7 commits behind head on main.

Files Patch % Lines
packages/ogre/src/repository.ts 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   80.93%   76.49%   -4.45%     
==========================================
  Files           6        6              
  Lines         341      302      -39     
  Branches       73       64       -9     
==========================================
- Hits          276      231      -45     
- Misses         40       50      +10     
+ Partials       25       21       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Feb 16, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node ./bin/post-install

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Member Author

nadilas commented Feb 16, 2024

Merge activity

  • Feb 16, 6:36 PM GMT+1: @nadilas started a stack merge that includes this pull request via Graphite.
  • Feb 16, 6:41 PM GMT+1: Graphite rebased this pull request as part of a merge.
  • Feb 16, 6:42 PM GMT+1: @nadilas merged this pull request with Graphite.

@nadilas nadilas changed the base branch from fix_array_features to main February 16, 2024 17:39
@nadilas nadilas merged commit cf7639b into main Feb 16, 2024
7 of 10 checks passed
Copy link

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant