[Xamarin.Android.Build.Tasks] ignore mdbs and non-portable pdbs #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only problem with this, we discussed on Slack: https://xamarinhq.slack.com/archives/C03CEGRUW/p1572625192284800 If you had a I need to figure out how we can warn for any |
jonathanpeppers
force-pushed
the
androidlegacysymbols
branch
2 times, most recently
from
e2ccb2a to
27c8465
Compare
Fixes: dotnet#2230 We currently spend some time during builds converting symbol files if `DebugType=Full` or `DebugType=PdbOnly` is used. These are older symbol formats, and we have already done the work to use `DebugType=Portable` everywhere in the Xamarin templates. My thought is to just remove support for these symbols by default unless `$(AndroidLegacySymbols)` is set to `True`. This way if a problem comes up, developers can opt-in to the old behavior. Eventually we may phase out support completely, but it may not matter to leave it in. I updated various tests here to make sure we continue to test both `Full` and `Portable` in `DebuggingTest.cs`. ~~ XA0122 ~~ I added a new warning, for cases where a PCL `<ProjectReference/>` have `DebugType=Full` set. This seems like the only likely cause a user could hit an issue. I added a test for this scenario. Other changes: * I found the `_CollectMdbFiles` MSBuild target is completely unused. It should have been removed in 2ea31e6, but we can remove it now. * I found a place `$(AllowedReferenceRelatedFileExtensions)` was adding duplicate values. We should have removed this in e390702.
jonathanpeppers
force-pushed
the
androidlegacysymbols
branch
from
27c8465 to
db98442
Compare
|
We are doing this in .NET 6 (see: aab69af), so this isn't needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2230
We currently spend some time during builds converting symbol files if
DebugType=FullorDebugType=PdbOnlyis used.These are older symbol formats, and we have already done the work to
use
DebugType=Portableeverywhere in the Xamarin templates.My thought is to just remove support for these symbols by default
unless
$(AndroidLegacySymbols)is set toTrue. This way if aproblem comes up, developers can opt-in to the old behavior.
Eventually we may phase out support completely, but it may not matter
to leave it in.
I updated various tests here to make sure we continue to test both
FullandPortableinDebuggingTest.cs.XA0122
I added a new warning, for cases where a PCL
<ProjectReference/>have
DebugType=Fullset. This seems like the only likely cause auser could hit an issue. I added a test for this scenario.
Other changes
_CollectMdbFilesMSBuild target is completely unused.It should have been removed in 2ea31e6, but we can remove it now.
$(AllowedReferenceRelatedFileExtensions)wasadding duplicate values. We should have removed this in e390702.