Fix path to TarTool in Sign.proj

[ViktorHofer]

Regressed with e0270d6

I verified that there is no hardcoded path to any other PackAsTool asset.

[akoeplinger]

ok as a quick fix but nobody will remember to update this place in the future.

What about doing something like:

<ItemGroup>
  <_TarToolPath Include="$(NuGetPackageRoot)microsoft.dotnet.tar\$(MicrosoftDotNetSignToolVersion)\tools\net*\any\Microsoft.Dotnet.Tar.dll" />
</ItemGroup>

[fhnaseer]

I would suggest logging an error/warning if tool is not found. Right now, it fails silently.

arcade/src/Microsoft.DotNet.SignTool/src/ZipData.cs

Line 249 in 7fff497

private static bool RunTarProcess(string srcPath, string dstPath, string tarToolPath)

[ViktorHofer]

I think that would include the net472 one as well. Arcade continues to have a few hardcoded TFMs, i.e. in #15221.

This is the only PackAsTool component that is directly referenced in Arcade. @ellahathaway / @mmitche would it make sense for SignTool to redistribute the TarTool and optionally reference it as a classlib?

[ViktorHofer]

Alternatively, it should be possible to save the TFM in Arcade's generated DefaultVersions.Generated.props file and then read from that here.

[mmitche]

I have a fix for the exit non-zero case in a local branch that should be up soon. That said, I don't think TarTool is actually in use. On framework it just bails:

https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Tar/Program.cs#L4-L9

And in signtool, we only use tartool on framework:

https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.SignTool/src/ZipData.cs#L248-L326

I will problaby rip it out.

[akoeplinger]

I think that would include the net472 one as well.

For the record it wouldn't since we only pack it as a tool in netcore.

[ViktorHofer]

Merging to unblock the broken scenario. Filed #15300