Allow filtering trace details with search #7600
Conversation
adamint
requested review from
Copilot,
JamesNK and
drewnoakes
and removed request for
Copilot
| [ | ||
| viewModel.Span.SpanId, | ||
| GetResourceName(viewModel.Span.Source), | ||
| SpanWaterfallViewModel.GetDisplaySummary(viewModel.Span), |
There was a problem hiding this comment.
Update GetDisplaySummary on the VM to save the summary in a string so it isn't recreated when searched for and displayed on the page. e.g.
public static string GetDisplaySummary(OtlpSpan span)
{
return _cachedDisplaySummary ??= BuildDisplaySummary(span);
}
...| @@ -169,6 +207,11 @@ private void UpdateDetailViewData() | |||
| return; | |||
| } | |||
|
|
|||
| private async Task HandleAfterFilterBindAsync() | |||
| { | |||
| await InvokeAsync(_dataGrid.SafeRefreshDataAsync); | |||
There was a problem hiding this comment.
When you search on the resources and structured logs page, if there are open details then they're closed.
I can't remember exactly why we did that, but this page should also close details (if open) to be consistent.
| @@ -93,6 +94,43 @@ private ValueTask<GridItemsProviderResult<SpanWaterfallViewModel>> GetData(GridI | |||
| Items = page.ToList(), | |||
| TotalItemCount = visibleSpanWaterfallViewModels.Count | |||
| }); | |||
|
|
|||
| // Return spans where any child span matches the filter. | |||
| List<SpanWaterfallViewModel> GetFilteredSpanWaterfalls(List<SpanWaterfallViewModel> viewModels) | |||
There was a problem hiding this comment.
Could you split this method out from the page, maybe put it on SpanWaterfallViewModel, and then write some unit tests for each scenario you mentioned on the page.
| // Return spans where any child span matches the filter. | ||
| List<SpanWaterfallViewModel> GetFilteredSpanWaterfalls(List<SpanWaterfallViewModel> viewModels) | ||
| { | ||
| var viewModelsToFilterMatch = new Dictionary<SpanWaterfallViewModel, bool>(); |
There was a problem hiding this comment.
Is this a perf optimization to avoid filtering a span multiple times when there are children? Could you add a comment.
| } | ||
|
|
||
| matchesFilter = span.Children.Any(AnyChildMatchFilter) || Filter(_filter, span); | ||
| viewModelsToFilterMatch.Add(span, matchesFilter); |
There was a problem hiding this comment.
Be defensive against a span show getting into the list multiple times to avoid a "key already exists" error.
| viewModelsToFilterMatch.Add(span, matchesFilter); | |
| viewModelsToFilterMatch.Add[span] = matchesFilter; |
| return matchesFilter; | ||
| } | ||
|
|
||
| bool Filter(string filter, SpanWaterfallViewModel viewModel) |
|
IS this a 9.1 bug? |
Description
Adds a search button to the filter detail page that filters out spans based on the following rule:
A span is visible if any of these are true:
(no filter)
(filter)
Fixes #4439
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):