Skip to content

Commit

Permalink
Depend on Microsoft.NET.Sdk (#4851)
Browse files Browse the repository at this point in the history
  • Loading branch information
hoyosjs authored Aug 13, 2024
1 parent e9ec47d commit 0d2e464
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
16 changes: 8 additions & 8 deletions eng/InstallRuntimes.proj
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
From Versions.props:
$(MicrosoftDotnetSdkInternalVersion) - .NET SDK to use for testing
$(MicrosoftDotnetSdkVersion) - .NET SDK to use for testing
$(InternalReleaseTesting) - if true, internal service release testing
$(PrivateBuildTesting) - if true, test against a locally built runtime
$(PrivateBuildTesting) - if true, test against a locally built runtime
@(RuntimeTestVersions) - runtime/aspnetcore versions to install and test against
From Arcade:
Expand Down Expand Up @@ -56,7 +56,7 @@
Installs the runtimes for the SOS tests, handles private runtime build support or cleans up the private build registry keys
-->

<Target Name="InstallTestRuntimes"
<Target Name="InstallTestRuntimes"
DependsOnTargets="CleanupVersionManifest;InstallRuntimesWindows;InstallRuntimesUnix;WriteTestVersionManifest;" />

<!--
Expand All @@ -67,7 +67,7 @@
Condition="$([MSBuild]::IsOsPlatform(Windows))"
Inputs="$(VersionsPropsPath)" Outputs="$(TestConfigFileName)">

<Exec Command="$(PowershellWrapper) &quot;&amp; { &amp;$(DotnetInstallScriptCmd) $(CommonInstallArgs) -Version $(MicrosoftDotnetSdkInternalVersion) }&quot;"
<Exec Command="$(PowershellWrapper) &quot;&amp; { &amp;$(DotnetInstallScriptCmd) $(CommonInstallArgs) -Version $(MicrosoftDotnetSdkVersion) }&quot;"
IgnoreStandardErrorWarningFormat="true" />

<Exec Command="$(PowershellWrapper) &quot;&amp; { &amp;$(DotnetInstallScriptCmd) $(CommonInstallArgs) %(RuntimeTestVersions.ExtraInstallArgs) -Version %(RuntimeTestVersions.RuntimeDownload) -Runtime dotnet }&quot;"
Expand All @@ -85,7 +85,7 @@
Condition="!$([MSBuild]::IsOsPlatform(Windows))"
Inputs="$(VersionsPropsPath)" Outputs="$(TestConfigFileName)">

<Exec Command="bash $(DotnetInstallScriptCmd) $(CommonInstallArgs) -Version $(MicrosoftDotnetSdkInternalVersion)"
<Exec Command="bash $(DotnetInstallScriptCmd) $(CommonInstallArgs) -Version $(MicrosoftDotnetSdkVersion)"
IgnoreStandardErrorWarningFormat="true" />

<Exec Command="bash $(DotnetInstallScriptCmd) $(CommonInstallArgs) %(RuntimeTestVersions.ExtraInstallArgs) -Version %(RuntimeTestVersions.RuntimeDownload) -Runtime dotnet"
Expand All @@ -101,8 +101,8 @@
Writes the Debugger.Tests.Versions.txt file used by the SOS test harness
-->

<Target Name="WriteTestVersionManifest"
Inputs="$(VersionsPropsPath)"
<Target Name="WriteTestVersionManifest"
Inputs="$(VersionsPropsPath)"
Outputs="$(TestConfigFileName)">

<ItemGroup>
Expand Down Expand Up @@ -131,7 +131,7 @@
</ConfigFileEntry>
</TestConfigFileLines>
</ItemGroup>

<WriteLinesToFile File="$(TestConfigFileName)" Lines="@(TestConfigFileLines->Metadata('ConfigFileEntry'))" Overwrite="true" WriteOnlyWhenDifferent="true" />

<Message Importance="High" Text="Created config file $(TestConfigFileName)" />
Expand Down
6 changes: 3 additions & 3 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>ccfe6da198c5f05534863bbb1bff66e830e0c6ab</Sha>
</Dependency>
<Dependency Name="Microsoft.Dotnet.Sdk.Internal" Version="9.0.100-preview.5.24253.16">
<Uri>https://github.com/dotnet/installer</Uri>
<Sha>fa261b952d702c6bd604728fcbdb58ac071a22b1</Sha>
<Dependency Name="Microsoft.NET.Sdk" Version="9.0.100-rc.1.24409.1">
<Uri>https://github.com/dotnet/sdk</Uri>
<Sha>43360291a50c9c7c471551f8f8363919d38014ea</Sha>
</Dependency>
<Dependency Name="Microsoft.AspNetCore.App.Ref.Internal" Version="9.0.0-rc.1.24411.2">
<Uri>https://github.com/dotnet/aspnetcore</Uri>
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<MicrosoftAspNetCoreAppRefInternalVersion>9.0.0-rc.1.24411.2</MicrosoftAspNetCoreAppRefInternalVersion>
<MicrosoftAspNetCoreAppRefVersion>9.0.0-rc.1.24411.2</MicrosoftAspNetCoreAppRefVersion>
<!-- dotnet/installer: Testing version of the SDK. Needed for the signed & entitled host. -->
<MicrosoftDotnetSdkInternalVersion>9.0.100-preview.5.24253.16</MicrosoftDotnetSdkInternalVersion>
<MicrosoftDotnetSdkVersion>9.0.100-rc.1.24409.1</MicrosoftDotnetSdkVersion>
</PropertyGroup>
<PropertyGroup>
<!-- Opt-in/out repo features -->
Expand Down

0 comments on commit 0d2e464

Please sign in to comment.