Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-assigned identity flow #44718

Merged
merged 23 commits into from
Feb 10, 2025
Merged

User-assigned identity flow #44718

merged 23 commits into from
Feb 10, 2025

Conversation

alexwolfmsft
Copy link
Contributor

@alexwolfmsft alexwolfmsft commented Feb 7, 2025 •
edited by github-actions bot
Loading

@dotnetrepoman dotnetrepoman bot added this to the February 2025 milestone Feb 7, 2025
scottaddie
scottaddie reviewed Feb 7, 2025
View reviewed changes
docs/azure/sdk/authentication/system-assigned-managed-identity.md Outdated Show resolved Hide resolved
docs/azure/sdk/authentication/user-assigned-managed-identity.md Outdated Show resolved Hide resolved
docs/azure/sdk/authentication/user-assigned-managed-identity.md Outdated Show resolved Hide resolved
docs/azure/sdk/authentication/user-assigned-managed-identity.md Outdated Show resolved Hide resolved
docs/azure/sdk/authentication/user-assigned-managed-identity.md Outdated Show resolved Hide resolved
docs/azure/sdk/authentication/user-assigned-managed-identity.md Outdated Show resolved Hide resolved
docs/azure/sdk/authentication/user-assigned-managed-identity.md Outdated Show resolved Hide resolved
docs/azure/sdk/includes/managed-identity-concepts.md Outdated Show resolved Hide resolved
@alexwolfmsft alexwolfmsft marked this pull request as ready for review February 7, 2025 21:51
scottaddie
scottaddie requested changes Feb 8, 2025
View reviewed changes
Copy link
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the system-assigned doc, there's the following text:

"If you need to use a user-assigned managed identity, visit the Manage user-assigned managed identities article for more information."

That link should go to the new user-assigned doc instead.

docs/azure/sdk/includes/managed-identity-concepts.md Outdated Show resolved Hide resolved
docs/azure/sdk/includes/managed-identity-concepts.md Outdated Show resolved Hide resolved
@alexwolfmsft alexwolfmsft merged commit d04c1eb into dotnet:main Feb 10, 2025
8 checks passed
@scottaddie scottaddie mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaddie scottaddie scottaddie approved these changes

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@CamSoper CamSoper Awaiting requested review from CamSoper CamSoper is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

Assignees
No one assigned
Labels
dotnet-azure/svc
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@alexwolfmsft @scottaddie