Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lock "compiler speclet" URL #10564

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

richardszalay
Copy link
Contributor

Summary

The "compiler speclet" URL in the System.Threading.Lock class documentation was missing the language version folder under proposals/.

@richardszalay
Copy link
Contributor Author

richardszalay commented Oct 14, 2024

Question: This PR is a like-for-like / as-is fix, but would it be better to link to the published document page rather than the GitHub URL? Let me know and I can update this PR accordingly

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 14, 2024
Copy link

Learn Build status updates of commit 6ddbbc5:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Threading/Lock.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@kouvel
Copy link
Member

kouvel commented Oct 15, 2024

Question: This PR is a like-for-like / as-is fix, but would it be better to link to the published document page rather than the GitHub URL? Let me know and I can update this PR accordingly

Thanks for fixing this! Yea that published link seems like a better one to put there, the above looks good to me.

@richardszalay
Copy link
Contributor Author

Great I'll update the PR with the published link.

Copy link

Learn Build status updates of commit 0aac76e:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Threading/Lock.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kouvel kouvel merged commit 18040da into dotnet:main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Threading community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants