Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected fixes for WinHttpHandler #10638

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Collected fixes for WinHttpHandler #10638

merged 7 commits into from
Nov 14, 2024

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Nov 4, 2024

Collected fixes for the docs while reading through WinHttpHandler.

not finished yet

Use "Hide whitespace changes" when reviewing.

Copy link

Learn Build status updates of commit f36f2ff:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/WinHttpHandler.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 40d5669:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/WinHttpHandler.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@ManickaP ManickaP marked this pull request as ready for review November 13, 2024 17:01
@ManickaP ManickaP requested a review from a team as a code owner November 13, 2024 17:01
@ManickaP ManickaP changed the title [WIP] Collected fixes for WinHttpHandler Collected fixes for WinHttpHandler Nov 13, 2024
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

Learn Build status updates of commit 3c26ae2:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Net.Http/WinHttpHandler.xml ⚠️Warning View Details

xml/System.Net.Http/WinHttpHandler.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Net.Security.SslProtocols'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Learn Build status updates of commit 2e3e486:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/WinHttpHandler.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@ManickaP ManickaP enabled auto-merge (squash) November 14, 2024 13:02
@ManickaP ManickaP merged commit b4df947 into dotnet:main Nov 14, 2024
4 checks passed
@ManickaP ManickaP deleted the win-http branch November 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants