-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't publish non-editor browsable logging APIs #9419
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Thank you. |
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit b83d7aa: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsFixes dotnet/extensions#4628
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Let's
@gewarren, is this change live yet? The doc page https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.loggermessagestate.classifiedtag?view=dotnet-plat-ext-8.0 is still there and it's listed in the ToC too. |
Fixes dotnet/extensions#4628