Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish non-editor browsable logging APIs #9419

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren requested a review from a team as a code owner October 30, 2023 22:12
@ghost ghost assigned gewarren Oct 30, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 30, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@RussKie
Copy link
Member

RussKie commented Oct 30, 2023

Thank you.
Could you please add few more as listed in dotnet/extensions#4628 (comment)?

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link

Learn Build status updates of commit b83d7aa:

✅ Validation status: passed

File Status Preview URL Details
xml/_filter.xml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ghost
Copy link

ghost commented Oct 31, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes dotnet/extensions#4628

Author: gewarren
Assignees: gewarren
Labels:

area-Extensions-Logging, needs-area-label

Milestone: -

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@gewarren gewarren merged commit 95c95e2 into main Oct 31, 2023
2 checks passed
@gewarren gewarren deleted the gewarren-patch-4 branch October 31, 2023 16:16
@KalleOlaviNiemitalo
Copy link

@gewarren, is this change live yet? The doc page https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.loggermessagestate.classifiedtag?view=dotnet-plat-ext-8.0 is still there and it's listed in the ToC too.

@gewarren gewarren mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-Logging needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoggerMessageState.ClassifiedTag is not hidden from docs, contrary to SuppressMessageAttribute
5 participants