Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting for MethodApplication #17556

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fix-14844

682a16b
Select commit
Loading
Failed to load commit list.
Draft

Improve error reporting for MethodApplication #17556

Merge branch 'main' into fix-14844
682a16b
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci failed Nov 6, 2024 in 50m 1s

Build #20241106.16 had test failures

Details

Tests

  • Failed: 154 (0.40%)
  • Passed: 36,748 (96.23%)
  • Other: 1,285 (3.37%)
  • Total: 38,187

Annotations

Check failure on line 10020 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L10020

(NETCORE_ENGINEERING_TELEMETRY=Test) Failure running tests

Check failure on line 10021 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L10021

Cmd.exe exited with code '1'.

Check failure on line 85373 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L85373

(NETCORE_ENGINEERING_TELEMETRY=Test) Failure running tests

Check failure on line 85374 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L85374

Cmd.exe exited with code '1'.

Check failure on line 1 in FSharp.Editor.Tests.Function argument applications.function application in middle of pipeline with two additional arguments

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Editor.Tests.Function argument applications.function application in middle of pipeline with two additional arguments

Assert.Equal() Failure: Values differ
Expected: 1
Actual:   0
Raw output
   at FSharp.Editor.Tests.SignatureHelpProvider.assertSignatureHelpForFunctionApplication(String fileContents, String marker, Int32 expectedArgumentCount, Int32 expectedArgumentIndex, String expectedArgumentName) in D:\a\_work\1\s\vsintegration\tests\FSharp.Editor.Tests\SignatureHelpProviderTests.fs:line 194
   at FSharp.Editor.Tests.Function argument applications.function application in middle of pipeline with two additional arguments() in D:\a\_work\1\s\vsintegration\tests\FSharp.Editor.Tests\SignatureHelpProviderTests.fs:line 572

Check failure on line 1 in FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown for method parameters

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown for method parameters

Assert.Equal() Failure: Collections differ
                                ↓ (pos 0)
Expected: FSharpList<TestHint> [{ Content = "value = "
  Location = (1, 42)
  Tooltip = "parameter value" }]
Actual:   mkSeq@177<TestHint>  []
Raw output
   at FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown for method parameters() in D:\a\_work\1\s\vsintegration\tests\FSharp.Editor.Tests\Hints\InlineParameterNameHintTests.fs:line 221

Check failure on line 1 in FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown correctly for inner bindings

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown correctly for inner bindings

Assert.Equal() Failure: Collections differ
                                ↓ (pos 0)
Expected: FSharpList<TestHint> [{ Content = "mapping = "
  Location = (3, 16)
  Tooltip = "parameter mapping" }, { Content = "mapping = "
  Location = (3, 53)
  Tooltip = "parameter mapping" }, { Content = "mapping = "
  Location = (3, 92)
  Tooltip = "parameter mapping" }]
Actual:   mkSeq@177<TestHint>  []
Raw output
   at FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown correctly for inner bindings() in D:\a\_work\1\s\vsintegration\tests\FSharp.Editor.Tests\Hints\InlineParameterNameHintTests.fs:line 549

Check failure on line 1 in FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown correctly in type constructors mixed with functions

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown correctly in type constructors mixed with functions

Expected subject to be a collection with 4 item(s), but {{ Content = "a = "
  Location = (3, 11)
  Tooltip = "field a" }, { Content = "b = "
  Location = (3, 31)
  Tooltip = "field b" }}"
"contains 2 item(s) less than"
"{{ Content = "a = "
  Location = (3, 11)
  Tooltip = "field a" }, { Content = "mapping = "
  Location = (3, 20)
  Tooltip = "parameter mapping" }, { Content = "list = "
  Location = (3, 23)
  Tooltip = "parameter list" }, { Content = "b = "
  Location = (3, 31)
  Tooltip = "field b" }}.

With configuration:
- Use declared types and members
- Compare enums by value
- Match member by name (or throw)
- Without automatic conversion.
- Be strict about the order of items in byte arrays
Raw output
   at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.CollectingAssertionStrategy.ThrowIfAny(IDictionary`2 context)
   at FluentAssertions.Equivalency.EquivalencyValidator.AssertEquality(EquivalencyValidationContext context)
   at FluentAssertions.Primitives.ObjectAssertions.BeEquivalentTo[TExpectation](TExpectation expectation, String because, Object[] becauseArgs)
   at FSharp.Editor.Tests.Hints.InlineParameterNameHintTests.Hints are shown correctly in type constructors mixed with functions() in D:\a\_work\1\s\vsintegration\tests\FSharp.Editor.Tests\Hints\InlineParameterNameHintTests.fs:line 675